Refactor ShareFileDialog to improve UI layout, error handling, and share link management

This commit is contained in:
Leon Bösche
2026-01-24 21:53:13 +01:00
parent b703a209d0
commit d8133347f0

View File

@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import '../services/api_client.dart'; import '../services/api_client.dart';
import '../theme/app_theme.dart'; import '../theme/app_theme.dart';
import '../theme/modern_glass_button.dart';
import '../injection.dart'; import '../injection.dart';
class ShareFileDialog extends StatefulWidget { class ShareFileDialog extends StatefulWidget {
@@ -24,7 +25,6 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
bool _isLoading = true; bool _isLoading = true;
String? _shareUrl; String? _shareUrl;
String? _error; String? _error;
late final TextEditingController _urlController = TextEditingController();
@override @override
void initState() { void initState() {
@@ -32,12 +32,6 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
_loadShareLink(); _loadShareLink();
} }
@override
void dispose() {
_urlController.dispose();
super.dispose();
}
Future<void> _loadShareLink() async { Future<void> _loadShareLink() async {
setState(() { setState(() {
_isLoading = true; _isLoading = true;
@@ -53,7 +47,6 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
if (response['exists'] == true) { if (response['exists'] == true) {
setState(() { setState(() {
_shareUrl = response['url']; _shareUrl = response['url'];
_urlController.text = _shareUrl!;
_isLoading = false; _isLoading = false;
}); });
} else { } else {
@@ -81,7 +74,6 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
setState(() { setState(() {
_shareUrl = response['url']; _shareUrl = response['url'];
_urlController.text = _shareUrl!;
_isLoading = false; _isLoading = false;
}); });
} catch (e) { } catch (e) {
@@ -106,7 +98,6 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
setState(() { setState(() {
_shareUrl = null; _shareUrl = null;
_urlController.clear();
_isLoading = false; _isLoading = false;
}); });
} catch (e) { } catch (e) {
@@ -129,15 +120,17 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
return Dialog( return Dialog(
backgroundColor: Colors.transparent, backgroundColor: AppTheme.primaryBackground,
child: ConstrainedBox( shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(16)),
constraints: const BoxConstraints(maxWidth: 500),
child: Container( child: Container(
decoration: AppTheme.glassDecoration, width: 500,
constraints: const BoxConstraints(maxHeight: 400),
padding: const EdgeInsets.all(24), padding: const EdgeInsets.all(24),
child: Column( child: Column(
mainAxisSize: MainAxisSize.min, mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.start, children: [
// Header
Row(
children: [ children: [
Text( Text(
'Share "${widget.fileName}"', 'Share "${widget.fileName}"',
@@ -147,6 +140,15 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
fontWeight: FontWeight.bold, fontWeight: FontWeight.bold,
), ),
), ),
const Spacer(),
IconButton(
onPressed: () => Navigator.of(context).pop(),
icon: Icon(Icons.close, color: AppTheme.secondaryText),
splashColor: Colors.transparent,
highlightColor: Colors.transparent,
),
],
),
const SizedBox(height: 16), const SizedBox(height: 16),
if (_isLoading) if (_isLoading)
const Center( const Center(
@@ -157,7 +159,23 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
), ),
) )
else if (_error != null) else if (_error != null)
Text(_error!, style: TextStyle(color: Colors.red[400])) Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
Text(
_error!,
style: TextStyle(color: AppTheme.errorColor),
textAlign: TextAlign.center,
),
const SizedBox(height: 16),
ModernGlassButton(
onPressed: _loadShareLink,
child: const Text('Retry'),
),
],
),
)
else else
Column( Column(
crossAxisAlignment: CrossAxisAlignment.start, crossAxisAlignment: CrossAxisAlignment.start,
@@ -167,28 +185,32 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
style: TextStyle(color: AppTheme.secondaryText), style: TextStyle(color: AppTheme.secondaryText),
), ),
const SizedBox(height: 16), const SizedBox(height: 16),
TextField( Row(
controller: _urlController, children: [
readOnly: true, Expanded(
child: Text(
_shareUrl!,
maxLines: 2, maxLines: 2,
decoration: InputDecoration( overflow: TextOverflow.ellipsis,
labelText: 'Share link', style: TextStyle(color: AppTheme.primaryText),
border: const OutlineInputBorder(), ),
suffixIcon: IconButton( ),
icon: const Icon(Icons.copy), const SizedBox(width: 16),
ModernGlassButton(
onPressed: _copyToClipboard, onPressed: _copyToClipboard,
child: const Icon(Icons.content_copy),
), ),
), ],
), ),
const SizedBox(height: 16), const SizedBox(height: 16),
Row( Row(
children: [ children: [
TextButton( ModernGlassButton(
onPressed: _revokeShareLink, onPressed: _revokeShareLink,
style: TextButton.styleFrom( child: Text(
foregroundColor: Colors.red[400], 'Revoke Link',
style: TextStyle(color: AppTheme.errorColor),
), ),
child: const Text('Revoke Link'),
), ),
const Spacer(), const Spacer(),
TextButton( TextButton(
@@ -202,7 +224,6 @@ class _ShareFileDialogState extends State<ShareFileDialog> {
], ],
), ),
), ),
),
); );
} }
} }