Fix PDF loading in public file viewer

- Change PDF viewer to use SfPdfViewer.network instead of loading bytes
- Remove _loadPdfBytes method and _pdfBytes variable
- Use direct network loading for better performance and reliability
- Add onDocumentLoadFailed callback for error handling
- Remove unused dart:typed_data import
This commit is contained in:
Leon Bösche
2026-01-25 15:23:01 +01:00
parent 86f0cb188e
commit a88121d465

View File

@@ -4,7 +4,6 @@ import 'package:web/web.dart' as web;
import 'dart:ui_web' as ui_web;
import 'package:syncfusion_flutter_core/theme.dart';
import 'package:syncfusion_flutter_pdfviewer/pdfviewer.dart';
import 'dart:typed_data';
import 'package:video_player/video_player.dart';
import 'package:flutter/foundation.dart' show kIsWeb;
import '../theme/app_theme.dart';
@@ -27,7 +26,6 @@ class _PublicFileViewerState extends State<PublicFileViewer> {
String? _error;
Map<String, dynamic>? _fileData;
VideoPlayerController? _videoController;
List<int>? _pdfBytes;
String? _videoViewType;
@override
@@ -52,11 +50,6 @@ class _PublicFileViewerState extends State<PublicFileViewer> {
_isLoading = false;
});
// Load PDF bytes if it's a PDF file
if (_isPdfFile()) {
await _loadPdfBytes();
}
// Initialize video player if it's a video file
if (_isVideoFile()) {
await _initializeVideoPlayer();
@@ -69,28 +62,6 @@ class _PublicFileViewerState extends State<PublicFileViewer> {
}
}
Future<void> _loadPdfBytes() async {
if (_fileData?['viewUrl'] != null) {
try {
final apiClient = getIt<ApiClient>();
// Extract the path from viewUrl and call it directly
final viewUrl = _fileData!['viewUrl'] as String;
final uri = Uri.parse(viewUrl);
final path = uri.path + (uri.query.isNotEmpty ? '?${uri.query}' : '');
final bytes = await apiClient.getBytes(path);
setState(() {
_pdfBytes = bytes;
});
} catch (e) {
// If loading fails, we'll show an error or fallback
setState(() {
_error = 'Failed to load PDF content.';
});
}
}
}
Future<void> _initializeVideoPlayer() async {
if (!kIsWeb) {
// For mobile, use VideoPlayerController
@@ -185,7 +156,6 @@ class _PublicFileViewerState extends State<PublicFileViewer> {
if (viewUrl == null) return const SizedBox();
if (_isPdfFile()) {
if (_pdfBytes != null) {
return Expanded(
child: SfTheme(
data: SfThemeData(
@@ -200,34 +170,20 @@ class _PublicFileViewerState extends State<PublicFileViewer> {
),
),
),
child: SfPdfViewer.memory(
Uint8List.fromList(_pdfBytes!),
child: SfPdfViewer.network(
viewUrl,
canShowScrollHead: false,
canShowScrollStatus: false,
enableDoubleTapZooming: true,
enableTextSelection: false,
onDocumentLoadFailed: (details) {
setState(() {
_error = 'Failed to load PDF content.';
});
},
),
),
);
} else if (_error != null) {
return Expanded(
child: Center(
child: Text(
_error!,
style: TextStyle(color: AppTheme.primaryText),
textAlign: TextAlign.center,
),
),
);
} else {
return const Expanded(
child: Center(
child: CircularProgressIndicator(
valueColor: AlwaysStoppedAnimation<Color>(AppTheme.accentColor),
),
),
);
}
} else if (_isVideoFile()) {
if (kIsWeb && _videoViewType != null) {
// Use HTML video element for web