Refactor account settings dialog to load user data based on auth state changes and improve error handling with snack bars

b0esche_cloud/lib/widgets/account_settings_dialog.dart

@@ -41,7 +41,6 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
     _currentPasswordController = TextEditingController();
     _newPasswordController = TextEditingController();
     _confirmPasswordController = TextEditingController();
-    _loadUserData();
   }
 
   @override
@@ -53,15 +52,6 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
     super.dispose();
   }
 
-  void _loadUserData() {
-    final authState = context.read<AuthBloc>().state;
-    if (authState is AuthAuthenticated) {
-      _currentUser = authState.user;
-      _displayNameController.text = _currentUser?.displayName ?? '';
-      _avatarUrl = _currentUser?.avatarUrl;
-    }
-  }
-
   Future<void> _pickAndUploadAvatar() async {
     try {
       final result = await FilePicker.platform.pickFiles(
@@ -135,12 +125,16 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
         // Update auth state
         context.read<AuthBloc>().add(UpdateUserProfile(updatedUser));
 
-        ScaffoldMessenger.of(
+        ScaffoldMessenger.of(context).showSnackBar(
-          context,
+          const SnackBar(content: Text('Profile updated successfully')),
-        ).showSnackBar(const SnackBar(content: Text('Profile updated')));
+        );
       }
     } catch (e) {
-      setState(() => _error = e.toString());
+      if (mounted) {
+        ScaffoldMessenger.of(
+          context,
+        ).showSnackBar(SnackBar(content: Text('Failed to update profile: $e')));
+      }
     } finally {
       setState(() => _isLoading = false);
     }
@@ -148,7 +142,11 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
 
   Future<void> _changePassword() async {
     if (_newPasswordController.text != _confirmPasswordController.text) {
-      setState(() => _error = 'Passwords do not match');
+      if (mounted) {
+        ScaffoldMessenger.of(
+          context,
+        ).showSnackBar(const SnackBar(content: Text('Passwords do not match')));
+      }
       return;
     }
 
@@ -160,9 +158,9 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
         newPassword: _newPasswordController.text,
       );
       if (mounted) {
-        ScaffoldMessenger.of(
+        ScaffoldMessenger.of(context).showSnackBar(
-          context,
+          const SnackBar(content: Text('Password changed successfully')),
-        ).showSnackBar(const SnackBar(content: Text('Password changed')));
+        );
       }
 
       // Clear fields
@@ -170,7 +168,11 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
       _newPasswordController.clear();
       _confirmPasswordController.clear();
     } catch (e) {
-      setState(() => _error = e.toString());
+      if (mounted) {
+        ScaffoldMessenger.of(context).showSnackBar(
+          SnackBar(content: Text('Failed to change password: $e')),
+        );
+      }
     } finally {
       setState(() => _isLoading = false);
     }
@@ -329,9 +331,20 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
 
   @override
   Widget build(BuildContext context) {
+    return BlocBuilder<AuthBloc, AuthState>(
+      builder: (context, authState) {
+        // Update user data when auth state changes
+        if (authState is AuthAuthenticated && _currentUser != authState.user) {
+          _currentUser = authState.user;
+          _displayNameController.text = _currentUser?.displayName ?? '';
+          _avatarUrl = _currentUser?.avatarUrl;
+        }
+
         return Dialog(
           backgroundColor: AppTheme.primaryBackground,
-      shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(16)),
+          shape: RoundedRectangleBorder(
+            borderRadius: BorderRadius.circular(16),
+          ),
           child: Container(
             width: 500,
             height: 700,
@@ -403,6 +416,8 @@ class _AccountSettingsDialogState extends State<AccountSettingsDialog> {
             ),
           ),
         );
+      },
+    );
   }
 
   Widget _buildTabButton(String text, int index) {